ProCamera2DTriggerBoundaries AreBoundariesRelative Bug

[flapierrelds]

Hello,

First of all, thanks for the great asset.

Working with ProCamera2DTriggerBoundaries, I've uncovered a bug where boundaries comparison does not consider AreBoundariesRelative flag when trying to avoid unnecessary transitions (procamera2dtriggerboundaries.cs IEnumerator Transition() around line 220). Since the code does not check if this flag is set, it will result in transition when the boundaries world space position are the same, which create a small visual glitch. I've fixed it on my side, but I though I would point it out to you. I can send you my code in private if you are interested.

Another question I have is that I've noticed that the transition between 2 different set of boundaries will always create a discontinuity in velocity on the camera since it lerp from the current position to the destination. Would it be possible to create a transition mode where the current camera's velocity is kept in order to remove this discontinuity? I can fix it on my side, but it is always easier for future versions integration when we do not have custom code in your system.

Thanks and have a nice day,
Francis

[Luís Pedro Fonseca]

Hi flapierrelds!

If you could send me the fixes you did for those bugs would be great.

The truth is that I've considered to remove this trigger from the package because the Rooms extension covers all the use-cases I can think of for these triggers, and does it in a much simpler way.

Have you tried the Rooms extension? If so, can you tell me why do you prefer the TriggerBoundaries?


Cheers!

[flapierrelds]

Hello,



I will send you the fix in private.



Yes, we did use the Room extension but then our boundaries become the trigger zone. Working on the camera constraints in our levels, we often have places where we want to change the camera boundaries at a given point (ex: climbing down of a rope) and have the upper boundary still be higher than the rope. ProCamera2DTriggerBoundaries allow us to do exactly that automatically. If we want to do this using the Room extension, we need to disable the automatic entry (Automatic Room Activation) and trigger this our self. This is not hard at all, it is just that ProCamera2DTriggerBoundaries exists and did what we needed. Would you say that using Room extension and creating the activation system our self is the way to go? We do not mind either way.


Have a nice day,
Francis

[Luís Pedro Fonseca]

I would say that if the TriggerBoundaries work well for you, it's fine. But the Rooms extension is a bit more flexible and more optimised.

Thanks for sending the fix!