ProCamera2DLimitDistance problem

[Nikaas]

Hi,

Noticed that ProCamera2DLimitDistance doesn't behave well in some situations.

I made a custom extension (based on ProCamera2DCameraWindow) that have the camera window move around the screen based on target position (actually based on CameraTargetPositionSmoothed) relative to camera position. But the thing about that extension is that camera window doesn't always "include" the center of the screen (and because the camera window in ProCamera2DCameraWindow always includes the center of the screen it works well with ProCamera2DLimitDistance). The actual problem with ProCamera2DLimitDistance - upon hitting one of the limits the extension resets  CameraTargetPositionSmoothed to the center of the screen and that reset of position disrupts the custom extension (suddenly CameraTargetPositionSmoothed is far out of the camera window).


The problem is in lines 77-79:

           ProCamera2D.CameraTargetPositionSmoothed = new Vector2(
               horizontalExtra ? Vector3H(ProCamera2D.LocalPosition) + horizontalDeltaMovement : ProCamera2D.CameraTargetPositionSmoothed.x,
               verticalExtra ? Vector3V(ProCamera2D.LocalPosition) + verticalDeltaMovement : ProCamera2D.CameraTargetPositionSmoothed.y);
I think ProCamera2DLimitDistance would work better if that code is replaced to:

           ProCamera2D.CameraTargetPositionSmoothed = new Vector2(
               horizontalExtra ? ProCamera2D.CameraTargetPositionSmoothed.x + horizontalDeltaMovement : ProCamera2D.CameraTargetPositionSmoothed.x,
               verticalExtra ? ProCamera2D.CameraTargetPositionSmoothed.y + verticalDeltaMovement : ProCamera2D.CameraTargetPositionSmoothed.y);

Edit: I played a bit more and saw the option to offset the camera window in ProCamera2DCameraWindow. If you offset the camera window to not include the center of the screen (say on x) and hit one of the side limits on ProCamera2DLimitDistance  you will notice the problem.



Nikola Kasabov

[Luís Pedro Fonseca]

Thanks Nikaas, you're right!

This fix will be part of the next release!

[Nikaas]

I don't know if you fixed it in some prev version but recently I updated pc2d and noticed that the last version have the bug.

[Luís Pedro Fonseca]

Hi Nikaas,

I'm going to investigate this and get back to you as soon as possible.

[Luís Pedro Fonseca]

Nikaas,

I've been looking at this and the reason I reverted back to the previous solution was because using the "CameraTargetPositionSmoothed" instead of the "LocalPosition", causes stuttering. If you do that change and test the included "Limit Distance" demo scene, you'll see what I mean.

At this point, I'm not exactly sure what to do so I'm going to need more time. Any suggestions?

[Nikaas]

You mean about that as if it's not the camera but the character that stutters?

Next seems to fix that:
ProCamera2D.CameraTargetPositionSmoothed = new Vector2(
horizontalExtra ? Vector3H(ProCamera2D.CameraTargetPositionSmoothed) + horizontalDeltaMovement  - Vector3H(originalDelta) : Vector3H(ProCamera2D.CameraTargetPositionSmoothed),
verticalExtra ? Vector3V(ProCamera2D.CameraTargetPositionSmoothed) + verticalDeltaMovement - Vector3V(originalDelta) : Vector3V(ProCamera2D.CameraTargetPositionSmoothed));



[Nikaas]

Luís Pedro Fonseca

Have you tried if this fixes the stuttering?

[Luís Pedro Fonseca]

Nikaas,

Sorry for the delay. Yes, that seems to have fixed the stutter and the issue you had previously. Great find!

I'll include it in the next update.


Thanks!