|
|
Post by mgregoirelds on May 25, 2017 17:55:17 GMT
Hello,
First thanks for the great product. It is really useful and it is working great!
I didn't know where to post this, as it's not really a bug, more of a suggestion... I've seen that there are quite a few places in the code base where #if UNITY_5 is used (mostly in UI related code). In these cases, the code will fallback to the #else case on Unity 2017. It's not a huge change and it could be easily done in a future version of ProCamera2D. That's it!
|
|
|
|
Post by Luís Pedro Fonseca on May 25, 2017 22:08:02 GMT
Hi @mgregoorelds, thanks for the heads up.
Can you tell me what do you mean with UI code?
|
|
|
|
Post by mgregoirelds on May 26, 2017 12:05:30 GMT
Can you tell me what do you mean with UI code? Here is an example on what I am seeing (ProCamera2DRoomsEditor.cs, line 125) : #if UNITY_5
EditorGUI.PrefixLabel(new Rect(rect.x + 200, rect.y, 65, 10), new GUIContent("Rect", "The room size and position"), EditorStyles.boldLabel);
#else
EditorGUI.PrefixLabel(new Rect(rect.x + 200, rect.y, 65, 10), new GUIContent("Rect", "The room size and position"));
#endifAs I said, it is not any stuff that break features. However, I am pretty sure you would want the behavior from 5.x to be same for 2017. There are similar places in the code where it is like this, e.g. ProCamera2DEditor.cs, ProCamera2DParallaxEditor.cs, ProCamera2DRailsEditor.cs... Thanks ! |
|
|
|
Post by Luís Pedro Fonseca on May 26, 2017 14:25:38 GMT
I see. You meant editor code.  You're right, that should be UNITY_5_OR_NEWER (or something similar). I'll take care of that for next release. Thanks!! |
|
|
|
Post by mgregoirelds on May 27, 2017 18:02:44 GMT
I see. You meant editor code. Ahah, yeah you are right, it's not UI. Sorry about that and thanks for looking at this. |
|
|
|
Post by vaulcul on Jul 18, 2017 23:21:27 GMT
Has this issue been fully addressed?
I still seem to be having problems in Unity 2017.
I have the following errors happening in the console:
Assets/ProCamera2D/Examples/TopDownShooter/Scripts/Enemy/EnemyAttack.cs(21,9): error CS0246: The type or namespace name `NavMeshAgent' could not be found. Are you missing `UnityEngine.AI' using directive?
Assets/ProCamera2D/Examples/TopDownShooter/Scripts/Enemy/EnemyPatrol.cs(18,9): error CS0246: The type or namespace name `NavMeshAgent' could not be found. Are you missing `UnityEngine.AI' using directive?
Assets/ProCamera2D/Examples/TopDownShooter/Scripts/Enemy/EnemyWander.cs(16,9): error CS0246: The type or namespace name `NavMeshAgent' could not be found. Are you missing `UnityEngine.AI' using directive?
|
|
|
|
Post by Luís Pedro Fonseca on Jul 19, 2017 9:53:57 GMT
vaulcul You need to update to the latest version. That issue has been resolved.
|
|
